Opened 15 months ago

Last modified 13 months ago

#20066 new enhancement

SImplify the functionality of script_concat_settings() and remove the globals

Reported by: azaozz Owned by:
Priority: normal Milestone: Future Release
Component: General Version:
Severity: normal Keywords:
Cc: eric.andrew.lewis@…

Description

As discussed in the comments on #20055, script_concat_settings() should be split into couple of simple functions that only check the constants and the 'can_compress_scripts' server option.

Change History (3)

There's an initial patch by ericlewis: http://core.trac.wordpress.org/attachment/ticket/20055/20055-3.patch

Not sure what the best back-compat option is here. Outright removing the globals would break plugins that use them. Seems we should move script_concat_settings() to deprecated.php and trigger the appropriate "deprecated" messages.

Then we can introduce simplified function that would return whether compression from PHP is supported by the server using CONCATENATE_SCRIPTS, COMPRESS_SCRIPTS and get_site_option('can_compress_scripts').

  • Cc eric.andrew.lewis@… added
  • Milestone changed from 3.4 to Future Release

This didn't make it in 3.4.

Note: See TracTickets for help on using tickets.