"Approve" should not be a bulk action when viewing spam comments

[nacin]

Approve, Quick Edit, and Edit action links are all hidden on edit-comments.php?comment_status=spam. The only action links are Not Spam and Delete Permanently. These are both bulk actions, but there is also an Approve bulk action.

No word on whether it works. Probably does. It should be removed for consistency, given that Restore simply returns it to the queue.

On the Trash view, there is no Approve bulk action, only Restore and Delete Permanently.

Replying to nacin:

No word on whether it works. Probably does. It should be removed for consistency, given that Restore simply returns it to the queue.

Not always - the result of hitting "Not Spam" depends on what the comment status was before it was marked as spam (using _wp_trash_meta_status).

This means that doing a bulk action of "Not Spam" can cause those comments to end up in different places (approved or pending). Maybe that's why the "Approve" action is also there? (On reflection, this doesn't make too much sense to me. I do think it's counter-intuitive that the result of hitting "Not Spam" is variable.)

the patch is working fine.... tested and verified..

Related: #17275

In [20533]:

Remove "Approve" bulk action when viewing spam comments as it isn't shown in the row actions. Props russellwwest. Fixes #20123.