Opened 14 months ago

Last modified 4 months ago

#20271 new defect (bug)

Un-marked up text in the Add Users admin section for multi-site

Reported by: topher1kenobe Owned by:
Priority: normal Milestone: Awaiting Review
Component: Users Version: 3.3.1
Severity: normal Keywords: has-patch ui-focus
Cc: joachim.kudish@…

Description

When looking at the page for adding a new user on a multi-site setup, the top option is to add an existing user.

This text: "Enter the email address or username of an existing user on this network to invite them to this site. That person will be sent an email asking them to confirm the invite."

has no html markup around it. Immediately above it is an h3 tag. The text should have a <p> around it at the very least.

My goal here is actually hide the whole section with css for some roles, but I have no way to refer to it.

Attachments (3)

20271-1.diff (1.2 KB) - added by jkudish 14 months ago.
adds a paragraph around the text with id "add-existing-user-text"
20271.2.patch (989 bytes) - added by SergeyBiryukov 14 months ago.
20271.3.patch (1.5 KB) - added by topher1kenobe 9 months ago.
My version wraps the entire area in a div and applies a simple p to the paragraph.

Download all attachments as: .zip

Change History (8)

adds a paragraph around the text with id "add-existing-user-text"

  • Cc joachim.kudish@… added
  • Keywords has-patch added

comment:2 follow-up: ↓ 3   helenyhou14 months ago

A thought - if the goal is to target via CSS, the adjacent sibling selector should do just fine, as in #add-existing-user + p. The paragraph tag probably doesn't really need an ID.

comment:3 in reply to: ↑ 2   jkudish14 months ago

Replying to helenyhou:

A thought - if the goal is to target via CSS, the adjacent sibling selector should do just fine, as in #add-existing-user + p. The paragraph tag probably doesn't really need an ID.

That's true. Added the ID just for the sake of it, though having it makes for a slightly more efficient css selector

My version wraps the entire area in a div and applies a simple p to the paragraph.

I've attached a patch of my own (my first, thanks markjaquith and jjj. It wraps the entire area in a wrapper div and puts the proper html on the contents.

  • Component changed from UI to Users
  • Keywords ui-focus added
Note: See TracTickets for help on using tickets.