XMLRPC: notices for missing arguments

[markoheijnen]

When arguments aren't pass there is a big chance a notice get fired.
When someone uses WP_Debug this can mean the XMLRPC will break

$args checks changes for all the XMLRPC methods

I wonder if that patch is really the right approach.

It might be better to have a guard condition at the top of each method that checks that $args is at least a minimum length. And if the guard fails, return a 400 status code error.

Sensible error messages help API consumers as well as prevent these PHP notices.

Was first thinking about that. Looking into the code I think for all methods it should work. Probably some need discussion.

One issue need to be fixed and that is in wp_editPost. $post_more isn't set what causes a notice

Alternative way

This is a first rough version of the guard condition version. A lot of unit test will fail since they also test if there are nog enough arguments passed.

I could go for 20394.guard.diff​ but we should enforce this for new methods only.

Added a refreshed patch that makes the method name a bit friendly and only applies to methods added in 3.4 for back-compat. I'm not sure whether we should make it cover the other wp.* methods, but at least we should avoid adding it to the legacy method namespaces.

In [20636]:

Introduce minimum_args() method in XML-RPC and leverage it to return errors for insufficient arguments for methods that are new in 3.4.

props maxcutler, markoheijnen.
fixes #20394.

The patch, used spaces instead of tabs, and 4 spaces at that. I happened to notice that as a result the code looked poorly formatted with a config using an 8 space tab.

Upcoming patch switches to tabs instead of spaces.

Use tabs instead of spaces

In [20703]:

We indent with spaces, not tabs. props sivel. fixes #20394.

Of course, we indent with tabs, not spaces.