Search result body classes not always applied

[johnbillion]

On search results pages a body class of 'search' is applied. This is correctly applied when is_search() is true.

A body class of 'search-results' and 'search-no-results' is also applied according to whether or not there are any results.

However, these two body classes are applied in an else block after a check for is_archive(), so this means if you filter your search results by post type (eg. s=my_search_term&post_type=my_post_type) then the 'search-results' and 'search-no-results' body classes are not applied because is_archive() is true.

Patch coming up.

Patch

In [20595]:

Always show search-results or search-no-results for searches, even archive searches. Props johnbillion. fixes #20435