Opened 14 months ago
Closed 14 months ago
#20508 closed defect (bug) (fixed)
3.4 Preview/Customize - "Save and Activate" doesn't save advanced theme settings (eg: 2011)
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.4 |
| Component: | Appearance | Version: | 3.4 |
| Severity: | normal | Keywords: | |
| Cc: | koopersmith |
Description
As an end user, if I am customizing an inactive theme and then press the "Save and Activate" button, I'm expecting that the theme I was customizing will be activated WITH the settings that I just customized.
For example:
- suppose I have the Carrington theme activated currently.
- I click the "Customize" link on the Twenty Eleven theme.
- Then I go and change the background colour.
- Now I click "Save and Activate".
- The Twenty Eleven theme is activated, but the background colour is not applied. The same is true if I change the background image, the header text colour etc.
- However, if I change the blog title or caption, that DOES get saved.
Browser tested with: Chrome
Change History (3)
comment:1
SergeyBiryukov
— 14 months ago
- Component changed from General to Themes
- Milestone changed from Awaiting Review to 3.4
comment:3
koopersmith
— 14 months ago
- Owner set to koopersmith
- Resolution set to fixed
- Status changed from new to closed
In [20584]:
Note: See
TracTickets for help on using
tickets.
From my testing, this happens when saving theme-specific features (like custom-background) not supported by current theme (e.g. Carrington 2.2).
Seems that the settings are saved on admin_init, which is after current theme mods (or a lack thereof) have been initialized on after_setup_theme.
WP_Customize_Setting::check_capabilities() then returns false, and the new theme mods are not applied in WP_Customize_Setting::save().