Opened 13 months ago

Closed 13 months ago

#20528 closed defect (bug) (fixed)

$parsed_url['query'] doesn't always exist

Reported by: johnjamesjacoby Owned by: duck_
Priority: normal Milestone: 3.4
Component: Canonical Version: 3.4
Severity: normal Keywords: has-patch commit
Cc:

Description

_remove_qs_args_if_not_in_url() assumes there is always an array item 'query' returned by parse_url.

Wrapping it in an empty check will suppress the notice and silently return the $query_string

Attachments (2)

20528.patch​ (717 bytes) - added by johnjamesjacoby 13 months ago.
20528.diff​ (885 bytes) - added by duck_ 13 months ago.

Download all attachments as: .zip

Change History (6)

comment:1   nacin — 13 months ago

  • Milestone changed from Awaiting Review to 3.4
  • Version set to 3.4

johnjamesjacoby — 13 months ago

duck_ — 13 months ago

comment:2   duck_ — 13 months ago

There should also be an else branch so that all of the query args to check get removed if the URL doesn't have a query string, see 20528.diff​.

comment:3   nacin — 13 months ago

  • Keywords commit added

Yes, looks good. Could use some direct unit tests.

comment:4   duck_ — 13 months ago

  • Owner set to duck_
  • Resolution set to fixed
  • Status changed from new to closed

In [20669]:

Prevent a notice: don't attempt to parse the query string if it doesn't exist. Props johnjamesjacoby. Fixes #20528.

Note: See TracTickets for help on using tickets.