Featured Image (Post Thumbnail) SSL Issue

[justindgivens]

If the wp-config FORCE_SSL_ADMIN constant has been set to true then the Featured Image within the Edit Post page will still load without HTTPS. This isn't a huge deal but it breaks the SSL on the page. Patch fixes this.

Patch for 20534

Can we get this included in 3.4?

Better fix instead of just for the post thumbnail. This fixes the Media and Media Edit pages as well.

We now have set_url_scheme() we can use here.

Updated with the new function.

Might this be considered for 3.5 or beyond?

Ran into this today – code works great, thanks! Sad I couldn't have contributed, ya'll are too fast ;]

Hi,
I ran into this problem with wordpress 3.4.2 today and manually patched it using the attached fix.
I also noticed that there's a bug in the latest fix: http://core.trac.wordpress.org/attachment/ticket/20534/20534.3.diff

The following if statement should have brackets:

        if ( $src && $width && $height ) 
                        if( is_admin() ) 
                                $src = set_url_scheme( $src, 'admin' ); 
                        else 
                                $src = set_url_scheme( $src ); 
                        return array( $src, $width, $height ); 
                return false; 
        } 

Like so:

                if ( $src && $width && $height ) {
                        if( is_admin() ) 
                                $src = set_url_scheme( $src, 'admin' ); 
                        else 
                                $src = set_url_scheme( $src ); 
                        return array( $src, $width, $height ); 
                }
                return false; 
        } 

Updated from last comments.