WordPress.org

Make WordPress Core

Opened 14 months ago

Closed 14 months ago

#20573 closed defect (bug) (fixed)

Press This CSS contains invalid, unused, and inconsistent properties

Reported by: helenyhou Owned by: nacin
Priority: normal Milestone: 3.4
Component: Press This Version:
Severity: normal Keywords: has-patch commit
Cc:

Description

The CSS block for .pressthis a contains an invalid property (background-image-repeat), an unused property (background-repeat), and irregular gradient declarations that also need more cross-browser work.

Attachments (2)

removing-invalid-property.diff​ (638 bytes) - added by georgestephanis 14 months ago.
20573.diff​ (1.4 KB) - added by helenyhou 14 months ago.

Download all attachments as: .zip

Change History (6)

georgestephanis — 14 months ago

comment:1 helenyhou — 14 months ago

Semi-related: #19957

helenyhou — 14 months ago

comment:2 helenyhou — 14 months ago

  • Keywords has-patch added

20573.diff​ cleans up and adds more browser support to the gradient declarations and also contains the changes from removing-invalid-property.diff​.

comment:3 SergeyBiryukov — 14 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.4

Tested in Firefox 12, Chrome 18, IE 8, Opera 11.62, Safari 5.1.5.

comment:4 nacin — 14 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20655]:

Fix some unused/bad CSS for Press This backgrounds and gradients. props georgestephanis, helenyhou. fixes #20573.

Note: See TracTickets for help on using tickets.