Opened 13 months ago

Closed 13 months ago

#20583 closed defect (bug) (fixed)

RTL style fixes for the install theme info sidebar

Reported by: ocean90 Owned by: ryan
Priority: normal Milestone: 3.4
Component: RTL Version: 3.4
Severity: normal Keywords: has-patch
Cc:

Description

See before.png and after.png.

Attachments (6)

20583.patch​ (1.6 KB) - added by ocean90 13 months ago.
before.png​ (94.9 KB) - added by ocean90 13 months ago.
after.png​ (93.4 KB) - added by ocean90 13 months ago.
20583.diff​ (1.1 KB) - added by ryan 13 months ago.
20673.use-rtl-star.patch​ (1.2 KB) - added by ocean90 13 months ago.
20583.2.diff​ (1.1 KB) - added by helenyhou 13 months ago.

Download all attachments as: .zip

Change History (15)

ocean90 — 13 months ago

ocean90 — 13 months ago

ocean90 — 13 months ago

comment:1 follow-up: ↓ 2   helenyhou — 13 months ago

Looks good. There's an issue with the sidebar collapse but it's not theme install specific.

comment:2 in reply to: ↑ 1   ocean90 — 13 months ago

Replying to helenyhou:

Right, this is fixed in #20585.

comment:3   ryan — 13 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [20673]:

RTL style fixes for the install theme info sidebar. Props ocean90. fixes #20583

comment:4   helenyhou — 13 months ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

There's a stars.rtl.png​ now, so ocean90's small hack can be removed.

ryan — 13 months ago

comment:5 follow-up: ↓ 7   ryan — 13 months ago

Like so?

ocean90 — 13 months ago

comment:6   ocean90 — 13 months ago

  • Keywords has-patch added; needs-patch removed

comment:7 in reply to: ↑ 5   ocean90 — 13 months ago

Replying to ryan:

Like so?

No, more like 20673.use-rtl-star.patch​.

helenyhou — 13 months ago

comment:8   helenyhou — 13 months ago

20583.2.diff​ gets rids of some unnecessary old star CSS from the RTL sheet and moves the new star CSS into the more appropriate spot, since it also affects the details in the list table. So maybe more like that.

comment:9   ryan — 13 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [20763]:

Use stars-rtl.png for RTL start support in the theme installer. Props helenyhou, ocean90. fixes #20583

Note: See TracTickets for help on using tickets.