Opened 13 months ago

Last modified 6 months ago

#20635 accepted defect (bug)

_pad_term_count get's stuck if there is a loop in the hierarchy

Reported by: westi Owned by: westi
Priority: normal Milestone: Future Release
Component: Taxonomy Version:
Severity: normal Keywords: westi-likes has-patch 3.6-early
Cc: westi, jkudish

Description

Ideally it should be impossible for a loop in a taxonomy hierarchy to exist.

But sometimes they do.

If one does exist then _pad_term_counts() gets stuck :(

When one of these does exist the category widget breaks the front page of your site.

We currently hook wp_check_term_hierarchy_for_loops on wp_update_term_parent and I wonder if there are other places we should be doing this check too.

Attachments (1)

20635.diff​ (1.4 KB) - added by jkudish 6 months ago.
add term hierarchy loop detection to _pad_term_counts()

Download all attachments as: .zip

Change History (7)

comment:1   nacin — 12 months ago

What's the goal here for 3.4?

comment:2   jane — 12 months ago

  • Keywords reporter-feedback added

Given that we are about to go RC, I'm thinking this should be a 3.5 thing.

comment:3   ryan — 12 months ago

  • Milestone changed from 3.4 to Future Release

Aye. This feels punt to me since it doesn't look like a regression. Bring it back (with patch) if disagreed.

comment:4   westi — 11 months ago

  • Keywords westi-likes 3.5-early added; reporter-feedback removed
  • Owner set to westi
  • Status changed from new to accepted

comment:5   jkudish — 6 months ago

  • Cc jkudish added

jkudish — 6 months ago

add term hierarchy loop detection to _pad_term_counts()

comment:6   jkudish — 6 months ago

  • Keywords has-patch 3.6-early added; needs-patch 3.5-early removed
Note: See TracTickets for help on using tickets.