Opened 13 months ago
Closed 11 months ago
#20644 closed defect (bug) (fixed)
Date in "Incoming Links" dashboard widget is never shown
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Administration | Version: | 2.5 |
| Severity: | normal | Keywords: | has-patch |
| Cc: |
Description
The Dashboard widget "Incoming Links" has a checkbox "Display item date?". The date is never shown because there are two variables which are not used, never set, and therefore the date is never displayed (wp-admin/includes/dashboard.php, line 823):
if ( !empty($show_author) || !empty($show_summary) )
I can see no reason for these conditions. Removing them will produce the expected output.
Attachments (2)
Change History (7)
SergeyBiryukov — 13 months ago
comment:1
SergeyBiryukov — 13 months ago
- Component changed from Widgets to Administration
- Keywords 3.5-early added
- Milestone changed from Awaiting Review to Future Release
- Version changed from 3.4 to 2.5
comment:2
SergeyBiryukov — 11 months ago
- Keywords 3.5-early removed
- Milestone changed from Future Release to 3.5
Seems like using %1, %3, and %4 in the second string could be confusing? Typo, or an attempt at standardizing the placeholders in the first string?
comment:4
in reply to:
↑ 3
SergeyBiryukov — 11 months ago
Replying to nacin:
Typo, or an attempt at standardizing the placeholders in the first string?
The latter. It's the same as the block in line 809 (all four strings share the same placeholders):
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/includes/dashboard.php#L809
Introduced in [6705]. Related: ticket:6432:1. Makes sense to remove them, I guess.
Should probably also combine the strings for better i18n support (20644.2.diff).