Opened 13 months ago

Closed 12 months ago

#20667 closed defect (bug) (fixed)

Cropping header image by height doesn't work with flexible height

Reported by: SergeyBiryukov Owned by: ryan
Priority: normal Milestone: 3.4
Component: Appearance Version: 3.4
Severity: normal Keywords:
Cc:

Description

  1. Add an image to Media Library which doesn't require cropping (1000x288 for Twenty Eleven).
  2. Go to Appearance → Header, click "Choose from image library".
  3. Select the image from point 1, click "Set as header"
  4. Crop the image by height only, e.g. to 1000x100, click "Crop and Publish".
  5. The original image is used, without any cropping.

Related: ticket:20657:10

Change History (2)

comment:1   SergeyBiryukov — 13 months ago

  • Keywords needs-patch removed

Introduced in [20706].

ticket:20657:20657.patch​ or ticket:20657:20657.8.patch​ would solve this.

comment:2   ryan — 12 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [20806]:

Create a new attachment and make a copy of the image when selecting an image from the image library. This prevents orphaning the header if the original attachment is deleted. This also prevents stomping of meta.

Add a button to skip cropping.

Props SergeyBiryukov
Fixes #20657 #20667

Note: See TracTickets for help on using tickets.