Opened 12 months ago

Closed 12 months ago

#20695 closed defect (bug) (fixed)

Use the right hook for the theme information tab

Reported by: ocean90 Owned by: koopersmith
Priority: normal Milestone: 3.4
Component: Appearance Version: 3.4
Severity: normal Keywords: has-patch
Cc:

Description

Otherwise the output will be before the <html> stuff, see ​http://cl.ly/GgOH

Attachments (2)

20695.patch​ (460 bytes) - added by ocean90 12 months ago.
20695.2.patch​ (1.1 KB) - added by ocean90 12 months ago.

Download all attachments as: .zip

Change History (6)

ocean90 — 12 months ago

comment:2   ocean90 — 12 months ago

If we use iframe_header and iframe_footer we can retain the current filter. It will also prevent the output of unnecessary HTML like the admin menu. Makes it a easier for #20696.

Last edited 12 months ago by ocean90 (previous) (diff)

ocean90 — 12 months ago

comment:3   koopersmith — 12 months ago

Smart patch.

comment:4   koopersmith — 12 months ago

  • Owner set to koopersmith
  • Resolution set to fixed
  • Status changed from new to closed

In [20812]:

Theme Installer: Prevent unnecessary admin code from printing and print markup in correct order. Remove dead code. props ocean90, fixes #20695.

Note: See TracTickets for help on using tickets.