Opened 12 months ago

Closed 12 months ago

#20723 closed defect (bug) (fixed)

wp.getPosts xmlrpc using "number" when it should be using "numberposts"

Reported by: djcp Owned by: ryan
Priority: normal Milestone: 3.4
Component: XML-RPC Version: 3.4
Severity: normal Keywords: api has-patch commit
Cc:

Description

See $SUBJECT. Using "number" to limit the number of posts returned is incorrect, as wp_get_recent_posts() expects this parameter to be called "numberposts".

A patch is attached to fix the parameter name to be "numberposts" - though we could have the API externally expose "number" yet give the parameter "numberposts" to wp_get_recent_posts().

Attachments (2)

20723.patch​ (1020 bytes) - added by SergeyBiryukov 12 months ago.
Also corrects PHPDocs
class-wp-xmlrpc-server.php.patch​ (570 bytes) - added by djcp 12 months ago.

Download all attachments as: .zip

Change History (10)

comment:1   djcp — 12 months ago

  • Keywords has-patch added

comment:2   djcp — 12 months ago

To clarify, this means setting the number of posts that wp.getPosts returns is busted.

SergeyBiryukov — 12 months ago

Also corrects PHPDocs

comment:3   SergeyBiryukov — 12 months ago

  • Milestone changed from Awaiting Review to 3.4

Related: #18433

The change happened in ticket:18433:wp.getPosts.6.patch​, the earlier patches used numberposts.

comment:4   ryan — 12 months ago

numberposts is ancient cruft. I'd rather not bubble it up. How about exposing number in wp.getPosts and passing it along as numberposts per the alternative suggested in the description.

djcp — 12 months ago

comment:5   djcp — 12 months ago

Done and attached. No changes necessary to the phpdocs (but thanks for that before, Sergey) as the external API provided by wp.getPosts is the same.

comment:6   SergeyBiryukov — 12 months ago

  • Keywords commit added

comment:7   ryan — 12 months ago

We need some wp_getPosts unit tests.

comment:8   ryan — 12 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [20846]:

Fix post limiting in wp_getPosts(). Props djcp. fixes #20723

Note: See TracTickets for help on using tickets.