Opened 12 months ago

Last modified 7 months ago

#20774 new defect (bug)

Flag an user as spam with any rol become a sub site flagged as spam (Multisite)

Reported by: j.conti Owned by:
Priority: normal Milestone: Future Release
Component: Multisite Version: 3.0
Severity: major Keywords: has-patch
Cc: johnjamesjacoby

Description

Hi,

Since many weeks, many WangGuard users were contacting me because they say WangGuard were flagging the sub sites as spam.

Thats not a WangGuard bug, is a WordPress issue.

Steps:

  • Create a Subsite, you can add the Super Admin like site admin.
  • Add a user like subscriber.
  • Flag that user as spam in /network/users.php

That site will be flagged as spam although the owner were the Super Admin.

I think WordPress has to look for the user rol and only flag the sub site as spam if the rol is Administrator.

This issue is in WP 3.3.1 and 3.4

Attachments (1)

spam-unspam-user.diff (1.7 KB) - added by wonderboymusic 9 months ago.

Download all attachments as: .zip

Change History (7)

  • Keywords needs-patch added

Confirmed.

  • Version changed from 3.4 to 3.0
  • Keywords has-patch added; needs-patch removed

Spamming a site when marking a spammy user makes absolutely no sense. The code in that file is pretty bad, not surprised. Patched. Also added cap check and validates $user.

  • Milestone changed from Awaiting Review to 3.5
  • Cc johnjamesjacoby added

Confirmed; happens on BuddyPress.org when I need to spam a user that's also a user on the codex. Assumed it was intentional, but would make sense this is a bug. Either way, it's odd behavior.

  • Milestone changed from 3.5 to Future Release

Using the spam tools in WP means your mileage may vary. I'd like to not fix this long-standing bug without including code to spam a site where the spammed user is an "owner" based on role or email address, as it would make existing spam tools in core more difficult to use.

Note: See TracTickets for help on using tickets.