WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 13 months ago

#20784 closed defect (bug) (fixed)

"Live Preview" rather than "Customize" after installing a theme

Reported by: nacin Owned by: ryan
Priority: normal Milestone: 3.4
Component: UI Version:
Severity: normal Keywords: has-patch
Cc:

Description

After installing a theme, we should use the terminology we decided on.

As the strings already exist, this is likely not an i18n-change.

Attachments (3)

20784.patch​ (2.5 KB) - added by SergeyBiryukov 13 months ago.
20784.2.patch​ (2.2 KB) - added by SergeyBiryukov 13 months ago.
20784.3.patch​ (3.3 KB) - added by SergeyBiryukov 13 months ago.

Download all attachments as: .zip

Change History (11)

SergeyBiryukov — 13 months ago

comment:1 SergeyBiryukov — 13 months ago

  • Keywords has-patch added

comment:2 ryan — 13 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [20957]:

"Live Preview" rather than "Customize" after installing/upgrading a theme. Props SergeyBiryukov. fixes #20784

comment:3 follow-up: nacin — 13 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Let's also add in a title attribute. We use __( 'Preview “%s”' ) in the list table.

SergeyBiryukov — 13 months ago

comment:4 in reply to: ↑ 3 SergeyBiryukov — 13 months ago

Replying to nacin:

Let's also add in a title attribute.

Done in 20784.2.patch​.

comment:5 nacin — 13 months ago

For the upgrader skin when the theme is active, we hide these links. We should keep the Live Preview link, rename it to Customize, and ditch the fallback preview link.

In the network admin, looks like we properly hide the activate and preview links, but only for the installer skin, not for the upgrader skin.

SergeyBiryukov — 13 months ago

comment:6 SergeyBiryukov — 13 months ago

20784.3.patch​ addresses the above suggestions.

We have __( 'Customize “%s”' ) on Manage Themes screen, so it's still not an i18n-change.

comment:7 ryan — 13 months ago

Looks good multi and single site, install and upgrade.

comment:8 ryan — 13 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [20958]:

Post theme upgrade/install tweaks.

  • Add title attributes to Live Preview links.
  • Show Customize instead of Live Preview after upgrading current theme.
  • Hide activate and preview links after theme upgrade when in the network admin.

Props SergeyBiryukov
fixes #20784

Note: See TracTickets for help on using tickets.