Opened 12 months ago
Closed 12 months ago
#20799 closed defect (bug) (fixed)
Theme Customizer: Reduce reliance on fixed positioning and make sidebar UI flexible
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.4 |
| Component: | Appearance | Version: | 3.4 |
| Severity: | minor | Keywords: | has-patch commit |
| Cc: |
Description
Since the outer shell of the customizer uses fixed positioning, we can shift fewer elements by moving to absolute positioning, which allows better use of the "right" property (as it's set to the parent element instead of the window). This can allow the width to only be declared in two locations, so the sidebar becomes easily stretchable (and adjustable via JS).
Patch attached, tested in Chrome, Safari, Firefox, Opera, IE9, and IE8.
Attachments (5)
Change History (13)
koopersmith — 12 months ago
koopersmith — 12 months ago
comment:1
koopersmith — 12 months ago
comment:2
koopersmith — 12 months ago
Hold the phone, helenyhou alerted me to another test case (overlays without sidebars; e.g. when opening the customizer).
koopersmith — 12 months ago
comment:3
koopersmith — 12 months ago
Fixed in latest patch. The overlay used in customize-loader.js is not an overlay with a sidebar, so let's not use that container class.
Latest patch looks good to me in FF and Chrome (on a limited testing environment at the moment), LTR and RTL. With patch on #20800 applied, also looks good for the install themes previewer.
- Keywords commit added
Patch looks good. For RTL, I increased the left value for .wp-full-overlay.collapsed .collapse-sidebar to prevent an overlapping of the button on the scrollbar.

Latest patch adds corresponding RTL changes.