Opened 12 months ago

Closed 12 months ago

#20814 closed defect (bug) (invalid)

Add a couple other caveats for catching tweets for oEmbed

Reported by: georgestephanis Owned by:
Priority: normal Milestone:
Component: General Version: 3.4
Severity: normal Keywords: needs-patch ux-feedback
Cc:

Description

Currently ​https://twitter.com/BrendonMacias23/status/206809360876322817/photo/1 doesn't catch as a tweet for oEmbeds. Let's fix that.

Change History (1)

comment:1   nacin — 12 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

I don't know if these should catch as a tweet. They're not — they're a link to an image. I am pretty sure if the image has two photos, you'd find that /photo/2 shows different content than /photo/1. It's up to Twitter to decide whether to serve up an oEmbed response for this.

We *could* limit the regex to avoid catching this kind of URL, but that ends up with the exact same user experience — nothing shows up. So by allowing the regex to catch this URL, we are forward compatible with a potential change on Twitter's side to serve up a response.

Note: See TracTickets for help on using tickets.