WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 8 months ago

#20837 closed defect (bug) (worksforme)

About WordPress: Wrap class/function names into code tags

Reported by: ocean90 Owned by: nacin
Priority: low Milestone:
Component: Help/About Version: 3.4
Severity: minor Keywords: has-patch rtl-feedback
Cc:

Description

Just needs some magic from Nacin for GlotPress.

Attachments (4)

20837.patch (721 bytes) - added by ocean90 13 months ago.
20837.2.patch (1.1 KB) - added by ocean90 13 months ago.
under-the-hood-code.png (78.2 KB) - added by ryan 13 months ago.
20837.3.patch (1.6 KB) - added by SergeyBiryukov 13 months ago.

Download all attachments as: .zip

Change History (16)

ocean9013 months ago

comment:1 ocean9013 months ago

  • Owner set to nacin
  • Status changed from new to assigned

comment:2 nacin13 months ago

<code>WP_Query</code> also.

ocean9013 months ago

ryan13 months ago

comment:3 ryan13 months ago

code in the h4 doesn't look quite nice, to me.

comment:4 ocean9013 months ago

In 3.3:

http://f.cl.ly/items/310b1X3U133c2F3o3K0q/Bildschirmfoto%202012-06-04%20um%2022.40.55.png

comment:5 follow-up: nacin13 months ago

  • Keywords rtl-feedback added

We just did this in 3.3: <h4 style="direction:ltr">is_main_query()</h4>

We can't do that so easily with the use of "API" there.

Perhaps we can just "unstyle" <code> inside an <h4>. We're mostly worried about the semantic value as well as RTL.

comment:6 azaozz13 months ago

Looks like the compromise is to use a css class that would keep certain text blocks like headers in LTR. That gives some flexibility. The other option would be to style places we don't want monotype fonts inside "code":

h1 code,
h2 code,
h3 code,
h4 code,
h5 code,
h6 code {
  font-family: sans-serif;
}
Last edited 13 months ago by azaozz (previous) (diff)

comment:7 in reply to: ↑ 5 SergeyBiryukov13 months ago

Replying to nacin:

We just did this in 3.3: <h4 style="direction:ltr">is_main_query()</h4>

Also <h4><?php _e( 'WP_Screen API' ); ?></h4>.

comment:8 ryan13 months ago

Or say "Faster Queries" and avoid tedium no one will appreciate.

comment:9 nacin13 months ago

  • Milestone changed from 3.4 to Awaiting Review
  • Priority changed from normal to low

Going to look into this, but not a priority if we don't get to it for 3.4 final.

comment:10 SergeyBiryukov13 months ago

Maybe "<h4>Faster Post Queries</h4>", then "<code>WP_Query</code> has been optimized..."

SergeyBiryukov13 months ago

comment:11 ocean9012 months ago

  • Milestone changed from Awaiting Review to 3.5
  • Severity changed from normal to minor

We should look at it again when we do a 3.5 about page.

comment:12 nacin8 months ago

  • Milestone 3.5 deleted
  • Resolution set to worksforme
  • Status changed from assigned to closed

Closing. We'll get it to our liking when we build the about page in November.

Note: See TracTickets for help on using tickets.