WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 13 months ago

#20841 closed defect (bug) (fixed)

Menu | RTL issues

Reported by: rasheed Owned by: ryan
Priority: normal Milestone: 3.4
Component: RTL Version: 3.4
Severity: major Keywords: has-patch
Cc:

Description

Please check attachment.

wp-admin/nav-menus.php

Attachments (4)

menu-fix-rtl.gif​ (113.2 KB) - added by rasheed 13 months ago.
20841.patch​ (960 bytes) - added by SergeyBiryukov 13 months ago.
20841.2.diff​ (1.2 KB) - added by helenyhou 13 months ago.
20841.3.patch​ (808 bytes) - added by SergeyBiryukov 13 months ago.

Download all attachments as: .zip

Change History (13)

rasheed — 13 months ago

comment:1 SergeyBiryukov — 13 months ago

  • Milestone changed from Awaiting Review to 3.4

SergeyBiryukov — 13 months ago

comment:2 SergeyBiryukov — 13 months ago

  • Keywords has-patch added

.howto span was replaced with .nav-menus-php .howto span in [18577], but not for RTL.

input[type="search"] { text-align: left; } was introduced in [20168] (a regression from 3.3).

helenyhou — 13 months ago

comment:3 helenyhou — 13 months ago

Patch looks good. Found one more thing to adjust - the placement of the down arrow for expanding/collapsing an item to edit. 20841.2.diff​

comment:4 ryan — 13 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [20998]:

RTL fixes. Props SergeyBiryukov, helenyhou. fixes #20841

comment:5 azaozz — 13 months ago

Did some testing and don't see the need for text-align on the type=search fields. Perhaps that was needed for an older version of a browser?

comment:6 nacin — 13 months ago

Yeah, I brought this up — really no reason for text-align to be forced here. georgestephanis also doesn't know where it came from. Per IRC, it can be removed, for both LTR and RTL.

comment:7 SergeyBiryukov — 13 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

SergeyBiryukov — 13 months ago

comment:9 ryan — 13 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [20999]:

Remove text-align on search input. Props SergeyBiryukov. fixes #20841

Note: See TracTickets for help on using tickets.