Failure to display admin menu on hover

[m0r7if3r]

In the latest release of WordPress 3.4 (21007), there is a bug with the admin menus. The reproduction steps are as follows:

1. Expand browser to over 900px width
2. Ensure menu is not collapsed
3. Ensure you are on a page that has a pop-out
4. Reduce browser width to 900px or less, thus causing the admin menu to auto-collapse (and removing the option of expanding it)

If you follow these steps, when you hover on the currently selected menu item, it will not display the child menu. I have confirmed this bug on multiple computers in the following browsers (assume latest version unless otherwise specified): Chrome 21, Chrome 19, Firefox 12, Firfox 13, Firefox 14, Opera 11, Internet Explorer 10, Internet Explorer 9, and Safari 5.1.7. I have also confirmed that the bug does not exist on WordPress 3.3.2 in any of these browsers.

Confirmed as well. Doesn't happen in 3.3.2.

Confirmed. Key point (which I missed at first) is "when you hover on the currently selected menu item".

Introduced in [20749].

see #20642

Page refresh doesn't help, the flyout is actually never displayed for an active responsively collapsed menu item.

20857.diff​ fixes the issue, came up with exactly the same patch.

Replying to SergeyBiryukov:

Page refresh doesn't help, the flyout is actually never displayed for an active responsively collapsed menu item.

20857.diff​ fixes the issue, came up with exactly the same patch.

If you remove

.no-js

from

.no-js #adminmenu .wp-has-submenu:hover .wp-submenu,

on line 1340 (of 21007) the issue resolves itself, but I am not sure if that affects anything else, since it's a rather large amount of CSS. You could, alternatively, add a :hover after the CSS properties started on line 1734, which create the issue.

Edit: code for the second method (must go after line 1740)

#adminmenu .wp-has-submenu:hover .wp-submenu{display:block;}

Patch looks good.

In [21012]:

Fix admin menu hover. Props koopersmith. fixes #20857

[21012] causes an issue when a browser window is wide, but short in height: 20857.overlapping.png​.

Support forums topic with a video demonstration:
​http://wordpress.org/support/topic/admin-sidebar-buggish-on-34-rc2-21036

20857.2.diff​ fixes that.

Yuck.

Ah, so that's why the check was needed. Thought it was left over from when the submenu for the current screen used to pop-out too.

20857.2.diff works well, +1.

Going to ask koopersmith to review this as well.

Not the issue that needs to be solved here but wo should think about for 3.5: the responsive collapse really shouldn't remove the ability for the user to expand the menu. If they would rather have it expanded, it should be up to them. If we really thought collapsed was the best UI, that's what we would have all the time.

In [21065]:

Prevent hoverIntent from shifting open, expanded admin menus if the entire submenu is not visible. props SergeyBiryukov, fixes #20857.