Opened 12 months ago
Closed 12 months ago
#20868 closed defect (bug) (fixed)
Live previewing locks the iFrame window & URL
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.4 |
| Component: | Appearance | Version: | 3.4 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: |
Description
When you switch themes using the "Save and Activate" button on a live-preview window, the iFrame stays persistent unless you move away from the theme panel. This can be a problem because:
1) The URL in the address bar stays as /wp-admin/customize.php?theme=xxxxxxxxx
This means you can't see the actual URL of where you are - possibly promoting phishing.
2) You can't live preview any theme you've previously previewed.
Steps for reproduction:
- Preview Theme X
- Click "Save and Activate"
- Preview Theme Y
- Click "Save and Activate"
- Try previewing Theme X again, but you will get a blank page now.
Attachments (1)
Change History (9)
comment:1
SergeyBiryukov — 12 months ago
- Component changed from Themes to Appearance
- Milestone changed from Awaiting Review to 3.4
comment:2
SergeyBiryukov — 12 months ago
Closed #20874 as a duplicate of point 1.
comment:3
koopersmith — 12 months ago
- Keywords needs-patch added
- Owner set to koopersmith
- Status changed from new to accepted
Sounds like something's up with pushState. I'll add it to my list.
koopersmith — 12 months ago
comment:4
koopersmith — 12 months ago
- Keywords has-patch needs-testing added; needs-patch removed
Patch should fix both of those issues. Also allows for events that have optional data.
comment:5
SergeyBiryukov — 12 months ago
20868.diff works. Tested in Firefox 12, Chrome 19, IE 8, Opera 11.64.
- Keywords commit added; needs-testing removed
Marking for final review.
Confirmed both points.
The steps in point 2 result in a blank screen with a spinner image. No JS errors in the console.