Opened 11 months ago

Closed 7 months ago

#20952 closed defect (bug) (wontfix)

Untranslatable strings in twenty eleven (3.4)

Reported by: thomask Owned by:
Priority: normal Milestone:
Component: Bundled Theme Version: 3.4
Severity: trivial Keywords:
Cc:

Description

several files in twenty eleven contains

<?php comments_popup_link( '<span class="leave-reply">' . __( 'Leave a reply', 'twentyeleven' ) . '</span>', __( '<b>1</b> Reply', 'twentyeleven' ), __( '<b>%</b> Replies', 'twentyeleven' ) ); ?>

This is untranslatable for that 90 % #13651

But there is allready a sollution on comments.php (row 33):

 printf( _n( 'One thought on &ldquo;%2$s&rdquo;', '%1$s thoughts on &ldquo;%2$s&rdquo;', get_comments_number(), 'twentyeleven' ), number_format_i18n( get_comments_number() ), '<span>' . get_the_title() . '</span>' );

Which uses multiple plurals format

And there is also problem with search.php, which uses 3 times

_e( 'Search', 'twentyeleven' );

but in three diferent context - label, placeholder and button, so translating it once will change it on 3 places with 3 slightly different meanings - english is probably the ongly language, where those three are same (and even in english i think, that "search" as placeholder for search form is not the best option.


Attachments (1)

20952.diff (1.1 KB) - added by obenland 7 months ago.

Download all attachments as: .zip

Change History (6)

  • Component changed from I18N to Bundled Theme

The change would require new translations for all languages on update. Since this issue hasn't come up earlier, it seems to me that the cost/benefit ratio is pretty high...

this is for new theme bundled with new WP version, where there will be anyway hundrets of new strings to translate anyway

I agree that the costs are greater than the benefits. Suggest closing as wontfix.

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Let's keep the context issue in mind for Twenty Thirteen, then.

Good point @thomask!

Note: See TracTickets for help on using tickets.