Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#20961 closed defect (bug) (fixed)

Network Themes “View version detail“ link needs the right overlay

Reported by: ocean90 Owned by: nacin
Priority: normal Milestone: 3.4.1
Component: Themes Version: 3.4
Severity: normal Keywords: has-patch
Cc:

Description

Current is too small, since it's still use Thickbox.

Screenshot: ​http://cl.ly/HN9D

Attachments (2)

20961.wp33.png​ (14.9 KB) - added by SergeyBiryukov 11 months ago.
20961.patch​ (842 bytes) - added by SergeyBiryukov 11 months ago.

Download all attachments as: .zip

Change History (8)

SergeyBiryukov — 11 months ago

comment:1 follow-up: ↓ 2   SergeyBiryukov — 11 months ago

In 3.1 to 3.3, "View version details" in network admin looks broken too (20961.wp33.png​).

The API no longer returns screenshot_url field.

comment:2 in reply to: ↑ 1   nacin — 11 months ago

Replying to SergeyBiryukov:

The API no longer returns screenshot_url field.

Fixed on the WP.org side.

SergeyBiryukov — 11 months ago

comment:3   SergeyBiryukov — 11 months ago

  • Keywords has-patch added; needs-patch removed

20961.patch​ makes the link consistent with the one on the regular Manage Themes screen (given that #20960 is fixed).

comment:4   nacin — 11 months ago

Looks good.

comment:5   nacin — 11 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21110]:

Fix 'View version details' link for network/themes.php. In 3.5 these should stop pointing to WP.org. props SergeyBiryukov, fixes #20961 for trunk.

comment:6   nacin — 11 months ago

In [21111]:

Fix 'View version details' link for network/themes.php. In 3.5 these should stop pointing to WP.org. props SergeyBiryukov, fixes #20961 for 3.4.

Note: See TracTickets for help on using tickets.