#21012 closed defect (bug) (fixed)

Dashboard plugin stats widget messing up plugin title

Reported by: georgestephanis Owned by: nacin
Priority: normal Milestone: 3.5
Component: General Version: 3.4
Severity: normal Keywords: has-patch commit
Cc:

Description

When a user's name has double-quotes in it, like Otto ( http://cloud.stephanis.info/1a3b2T432N090G0z3T2Q ), the line in the code

if ( preg_match( '/"(.*)"/s', $item->get_title(), $matches ) )

escapes the title from

Samuel "Otto" Wood on "Facebook"

to

Otto" Wood on "Facebook

Let's actually make it sniff for the on before the double-quote to avoid this.

Attachments (1)

21012.diff (593 bytes) - added by georgestephanis 11 months ago.

Download all attachments as: .zip

Change History (7)

For the record, what this bug results in on the dashboard screen is:

http://cloud.stephanis.info/2x2O3c3o0L0f2P3t3U04

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.5

For the time being I've removed the quotes in my name, but seriously, this is stupid.

To avoid any potential conflicts, let's just change the RSS feeds on WP.org to remove the name, then remove those lines of code, leaving the forward-compatible lines.

Deploying the change to WP.org.

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21160]:

WP.org no longer returns this old structure. The title of the item is the plugin name in full. fixes #21012.

Note: See TracTickets for help on using tickets.