Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#21021 closed defect (bug) (fixed)

Unable to drag to empty second column on dashboard

Reported by: ActionNerd Owned by: azaozz
Priority: normal Milestone: 3.4.1
Component: Administration Version: 3.4
Severity: minor Keywords: has-patch
Cc:

Description

If, for whatever reason, the second column on the dashboard is empty it appears to be impossible to drag new panels over.

Tried it with the default theme installed by first dragging all the panels to the first column. Once they're all in the first column, can no longer add to second column.

Attachments (3)

21021.diff (463 bytes) - added by helenyhou 11 months ago.
21021.patch (455 bytes) - added by azaozz 11 months ago.
21021-2.patch (552 bytes) - added by azaozz 11 months ago.
Remove one more unneeded :empty

Download all attachments as: .zip

Change History (18)

Can't reproduce. What browser, OS?

Chrome v19.0.1084.56
Firefox v13.0.1
OS X v10.7.4

I've made a small little movie file so you can see just in case: http://theexperiment.ca/files/dashboard.mov

What plugins are active, if any? I can see a plugin update notice in the movie, but it might be deactivated, right?

No active plugins.

Also a fresh install.

I reproduced on trunk with @ActionNerd's steps.

  1. On dashboard, move all widgets to left column.
  2. Try to move a widget to right column. Notice there will be no dashed option in the right column to move widget to.

So I'm not crazy? Well that's a first. Thanks!

comment:7 follow-up: ↓ 10   nacin11 months ago

  • Component changed from General to Administration
  • Milestone changed from Awaiting Review to 3.4.1

This is an issue with responsiveness.

At a certain width of the screen, widgets remain in the second column, but once removed, they can no longer go back. If you make your window wider, eventually the dashed option will show up.

It happens at 1200 pixels. But two columns of full widgets don't wrap to one column until 800 pixels. These two values should probably be the same, at 800 pixels.

  • Keywords has-patch added

I feel like it can't possibly be this simple, but in my testing this worked: 21021.diff

  • Owner set to azaozz
  • Status changed from new to assigned

comment:10 in reply to: ↑ 7   azaozz11 months ago

Patch looks good. As far as I remember this line was there to prevent the border when auto-switching to one column and the second column is empty, but that's handled few lines above.

  • Resolution set to fixed
  • Status changed from assigned to closed

In [21093]:

Fix dragging to empty second column on dashboard, props helenyhou, fixes #21021 for 3.4

In [21094]:

Fix dragging to empty second column on dashboard, props helenyhou, fixes #21021 for trunk

  • Resolution fixed deleted
  • Status changed from closed to reopened

Another related regression: IE8 doesn't like :empty and discards the other selector too. That results in not expanding the drop area, same as above.

Remove one more unneeded :empty

  • Resolution set to fixed
  • Status changed from reopened to closed

In [21098]:

Fix dragging to empty second column in IE8, fixes #21021 for 3.4

In [21099]:

Fix dragging to empty second column in IE8, fixes #21021 for trunk

Note: See TracTickets for help on using tickets.