Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#21081 closed enhancement (fixed)

Whitelist the tel: and fax: URL protocols.

Reported by: markjaquith Owned by: markjaquith
Priority: low Milestone: 3.5
Component: General Version: 3.4
Severity: minor Keywords: has-patch 2nd-opinion
Cc:

Description

We should support telephone and fax number URLs, by whitelisting their protocols: tel: and fax:

http://www.ietf.org/rfc/rfc2806.txt

e.g.

tel:2025551234

Attachments (2)

21081.diff (1.3 KB) - added by markjaquith 11 months ago.
21081.2.diff (1.4 KB) - added by markjaquith 11 months ago.

Download all attachments as: .zip

Change History (9)

  • Keywords has-patch 2nd-opinion added; needs-patch removed
  • Owner set to markjaquith
  • Status changed from new to accepted

I thought we had added the filter for adding more protocols, see #18268.

comment:3 follow-up: ↓ 7   markjaquith11 months ago

We added a filter. Doesn't mean we shouldn't add some more defaults. Telephone links are particularly handy for local businesses creating mobile sites.

You have +1 from me.

.2 patch makes the edit_user() call use wp_allowed_protocols(), so there are no other places to keep having to update this protocol list.

  • Resolution set to fixed
  • Status changed from accepted to closed

In [21170]:

Allow tel: and fax: protocols. Wrangle the last hardcoded protocol enumeration so that it uses wp_allowed_protocols(). fixes #21081

comment:7 in reply to: ↑ 3   ocean9011 months ago

Replying to markjaquith:

We added a filter. Doesn't mean we shouldn't add some more defaults. Telephone links are particularly handy for local businesses creating mobile sites.

Yeah, of course. I just saw the changed line in wp-admin/includes/user.php which doesn't used wp_allowed_protocols. But now it does and I'm happy.

Note: See TracTickets for help on using tickets.