The 'allowed_themes' filter has disappeared

[johnbillion]

r20029 deprecated the get_allowed_themes() function and replaced it with wp_get_themes( array( 'allowed' => true ) ). This also removed the allowed_themes filter.

1. Is there a replacement filter?
2. If not, can the allowed_themes filter be reinstated?

And just to add a little more context, the allowed_themes filter could previously be used to filter the themes shown on the Themes screen on sites within a network. This is no longer possible.

Yeah, this should be added back to WP_Theme. Seems like WP_Theme::get_allowed() would make the most sense, as there was no filter in wpmu_get_blog_allowedthemes() or get_site_allowed_themes().

In 3.3, only get_site_allowed_themes() part was filtered:
http://core.trac.wordpress.org/browser/tags/3.3.3/wp-admin/includes/theme.php#L149

The patch assumes that it would make sense to filter the whole returned array.

Replying to SergeyBiryukov:

The patch assumes that it would make sense to filter the whole returned array.

Not sure that's a good assumption. The filter only acts on a network-wide array, with no context for the blog_id being requested.

We should add in some new filters.

21099.2.patch​ is another take.

allowed_themes should mirror the 3.3 behaviour. site_allowed_themes is a new filter, which passes $blog_id for context.

Wouldn't the 'site_allowed_themes' make more sense inside the get_allowed_on_site() method?

Replying to scribu:

Wouldn't the 'site_allowed_themes' make more sense inside the get_allowed_on_site() method?

Indeed. Added network_allowed_themes as well for consistency.

In [21686]:

Restore the 'allowed_themes' filter.

This filter has wrapped the network-wide themes, outside of the network-wide
allowed function (dating back to MU), hence the unusual placement. This restores
previous behavior; we will introduce new filters to enable greater flexibility.

see #21099.
for trunk.

In [21699]:

Restore the 'allowed_themes' filter.

This filter has wrapped the network-wide themes, outside of the network-wide
allowed function (dating back to MU), hence the unusual placement. This restores
previous behavior; we will introduce new filters to enable greater flexibility.

see #21099.
for the 3.4 branch.