Opened 11 months ago

Last modified 3 months ago

#21138 closed defect (bug)

Comments rewrite contains bogus rule — at Version 1

Reported by: nacin Owned by:
Priority: normal Milestone: 3.6
Component: Rewrite Rules Version:
Severity: normal Keywords: has-patch commit 3.6-early
Cc:

Description (last modified by nacin) 

[comments/feed/(feed|rdf|rss|rss2|atom)/?$] =>
    index.php?&feed=$matches[1]&withcomments=1

[comments/(feed|rdf|rss|rss2|atom)/?$] =>
    index.php?&feed=$matches[1]&withcomments=1

[comments/page/?([0-9]{1,})/?$] =>
    index.php?&paged=$matches[1]

That last rule doesn't make any sense. We should call generate_rewrite_rules() with $paged = false here.

Change History (1)

comment:1   nacin — 11 months ago

  • Description modified (diff)

I found this when porting over the test_query.php unit tests:

// 'comments/page/?([0-9]{1,})/?$' => 'index.php?&paged=$matches[1]',
function test_comments_page() {
       $this->http('/comments/page/2/');
       $this->assertQueryTrue('is_home', 'is_paged');
}
Note: See TracTickets for help on using tickets.