Kill use of colons in class names
|Reported by:||markjaquith||Owned by:||azaozz|
|Cc:||azizur, jack@…, aesqe@…|
Some of the WordPress admin uses class names with colon-separated values that have special meanings in our JS code This is a bad idea. Colons are a special character in CSS selector engines.
See #21106 for a really odd bug that cropped up because a css class contained the text foo:event which got parsed as an :even pseudo-class in JS.
HTML5 data attributes are the better way forward, in terms of attaching data to dom elements. We should kill all instances of colons in favor of data attributes.
Change History (36)
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 3.5
comment:27 follow-up: ↓ 29 arena — 12 months ago
- Resolution fixed deleted
- Status changed from closed to reopened