Underscores get stripped out in $type ( get_query_template() )

[rinatkhaziev]

What happens is:

$type = preg_replace( '|[^a-z0-9-]+|', '', $type );

strips underscore. Effectively, incoming "front_page" becomes frontpage, which leads to not working (but documented) hook front_page_template.

I tested this on: nginx 1.2.1/php-fpm 5.4.3 (homebrew macos) and nginx 1.0/php-fpm 5.3.3 with the latest revision ATM

The fix is as simple as

$type = preg_replace( '|[^a-z0-9-_]+|', '', $type );

Patch is attached.

proposed patch for the bug

Also mentioned in ticket:15337:9.

Replying to SergeyBiryukov:

Also mentioned in ticket:15337:9.

This is related to your link for sure, the only thing is that front page would be left as "front-page" instead of "front_page". front_page_template is the hook for modifying template hierarchy.

Related: [7223], [7224]. template_php.patch​ seems sane.

An alternative would be to rename the filter to front-page_template: 21213.patch​.

$type[0]_$type[1]_template filter would need the same change for consistency, see #15337.

I was getting ready to report this same bug for the attachment page template file $mimetype_$subtype.php. For example, template files text_plain.php and image_jpeg.php will not work but textplain.php and imagejpeg.php do work. The template_php.patch fix will resolve this issue also, but 21213.patch obviously won't.

Version number indicates when the bug was initially introduced/reported.

Note that both patches change the name of the filter fired for the front page template. I did a quick check on the plugins directory, this can break at least one plugin which filters frontpage_template: ​http://plugins.trac.wordpress.org/browser/page-transitions/trunk/main.php#L33

Haven't found any others, but I did find three plugins that filter on front_page_template:

• app-your-wordpress-uppsite/themes/webapp/functions.php
• commentpress-core/themes/commentpress-theme/functions.php
• wparty/wparty-theme.php