Opened 11 months ago

Closed 10 months ago

#21242 closed defect (bug) (fixed)

Twenty Twelve: HTML elements outside of .entry-content need styling

Reported by: obenland Owned by: lancewillett
Priority: normal Milestone: 3.5
Component: Bundled Theme Version:
Severity: normal Keywords:
Cc: lancewillett, drewstrojny

Description

Specifically the password form for password protected posts and HTML elements inside of comments.

Screenshots will be attached.

Attachments (3)

comment-text.png​ (149.7 KB) - added by obenland 11 months ago.
passwordform.png​ (23.7 KB) - added by obenland 11 months ago.
21242.diff​ (6.3 KB) - added by drewstrojny 10 months ago.

Download all attachments as: .zip

Change History (14)

obenland — 11 months ago

obenland — 11 months ago

comment:1   SergeyBiryukov — 11 months ago

  • Milestone changed from Awaiting Review to 3.5

drewstrojny — 10 months ago

comment:2   drewstrojny — 10 months ago

Attachment 21242.diff styles the necessary password protected post elements and HTML elements inside of comments. Thanks obenland!

comment:3   drewstrojny — 10 months ago

  • Cc dstrojny@… added

comment:4   lancewillett — 10 months ago

  • Cc drewstrojny added; dstrojny@… removed

comment:5   lancewillett — 10 months ago

  • Keywords needs-patch needs-ui removed

@drewstrojny Patch is looking good, will commit shortly. The only change is removing the "alignleft, alignright, aligncenter" rules, I don't think those apply to comment content.

comment:6   lancewillett — 10 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21277]:

Twenty Twelve: add styles for common HTML elements in comment content, and also style up password protected form. Props drewstrojny, fixes #21242.

comment:7   obenland — 10 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Styles still don't get applied, since comment content is missing the 'comment-content' CSS class. Currently it has 'post-content'.

Should I submit a patch? :)

comment:8 follow-ups: ↓ 9 ↓ 10   Jayjdk — 10 months ago

What is the reason for using something like .entry-content pre, .comment-content pre instead of just pre ?

comment:9 in reply to: ↑ 8   obenland — 10 months ago

Replying to Jayjdk:

What is the reason for using something like .entry-content pre, .comment-content pre instead of just pre ?

Related: #21379 (Nr. 2)

comment:10 in reply to: ↑ 8   lancewillett — 10 months ago

Replying to Jayjdk:

What is the reason for using something like .entry-content pre, .comment-content pre instead of just pre ?

This is important so that plugin or widget output isn't styled, in the case of main content HTML elements we want to specifically focus on comment area and content area of posts and pages only.

comment:11   lancewillett — 10 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [21371]:

Twenty Twelve: fix typo for comment-content container showing incorrect class value, props obenland. Closes #21242.

Note: See TracTickets for help on using tickets.