Opened 10 months ago
Closed 10 months ago
#21255 closed defect (bug) (fixed)
Twenty Twelve: Tag and category descriptions should not be part of H1 tag
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | ui-feedback |
| Cc: | lancewillett |
Description
Ticket based on Lance's comment.
If we do change that, we would also have to come up with a design decision on how to display the description.
Attachments (5)
Change History (12)
21255.2.diff proposes a <header> tag like in search.php, wrapping title and desc, to have only one baseline no matter whether there is a description or not.
Descriptions styling is essentially like .archive-title sans boldness.
See archive-descriptions-21255.png for result.
comment:3
in reply to:
↑ 2
lancewillett — 10 months ago
Chatted with Drew on this today, we agreed it's not intentional to have the div elements nested inside the h1 elements.
@obenland Thanks for the patch, I'll take a look soon and get this in.
comment:4
lancewillett — 10 months ago
In [21331]:
comment:5
lancewillett — 10 months ago
- Keywords ui-feedback added; needs-ui has-patch removed
Leaving open for @drewstrojny to look at the design / CSS for the output for tag and category descriptions.
drewstrojny — 10 months ago
drewstrojny — 10 months ago
comment:6
drewstrojny — 10 months ago
This is good to go on my end. See 21255.3.diff and associated screenshot.
comment:7
lancewillett — 10 months ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In [21397]:

Addresses the archive.php part of the change. Style still missing.