Opened 10 months ago

Closed 10 months ago

#21297 closed enhancement (fixed)

Twenty Twelve: Use PHP5 constructor and visibility keywords in theme options class

Reported by: Mamaduka Owned by: lancewillett
Priority: normal Milestone: 3.5
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch
Cc:

Description

As WordPress requires PHP5 I think it's better if we use same version constructor.

Attachments (3)

21297.diff​ (548 bytes) - added by Mamaduka 10 months ago.
21297.2.diff​ (2.8 KB) - added by obenland 10 months ago.
Adds visibility keywords
21297.3.diff​ (4.0 KB) - added by obenland 10 months ago.
Added documentation

Download all attachments as: .zip

Change History (8)

Mamaduka — 10 months ago

comment:1   Mamaduka — 10 months ago

  • Keywords has-patch added

comment:2   nacin — 10 months ago

  • Milestone changed from Awaiting Review to 3.5

Same goes for visibility.

obenland — 10 months ago

Adds visibility keywords

obenland — 10 months ago

Added documentation

comment:3   ocean90 — 10 months ago

  • Component changed from General to Bundled Theme

comment:4   lancewillett — 10 months ago

  • Summary changed from Twenty Twelve: Use PHP5 constructor in theme options class to Twenty Twelve: Use PHP5 constructor and visibility keywords in theme options class

This is great, thanks for the ticket and patch. Agreed on going with the correct PHP5 notation.

comment:5   lancewillett — 10 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21280]:

Twenty Twelve: update theme options file to use PHP5 constructor and visibility keywords, and also minor DocBlock cleanup. Props Mamaduka and obenland, closes #21297.

Note: See TracTickets for help on using tickets.