Opened 10 months ago

Closed 10 months ago

#21317 closed enhancement (fixed)

Should "_media_button" function be deprecated?

Reported by: martythornley Owned by: ryan
Priority: normal Milestone: 3.5
Component: Media Version:
Severity: normal Keywords: needs-patch
Cc:

Description

Looking at media uploads, looks like the function _media_button is not used anywhere? defined in media.php line 389 but can't find it used anywhere?

Change History (4)

comment:1   scribu — 10 months ago

  • Keywords needs-patch added

I guess since there's only one button now, we don't need it.

I think we can just remove it outright.

comment:2   SergeyBiryukov — 10 months ago

Unused since [18890].

Related: #20427

comment:3   nacin — 10 months ago

  • Milestone changed from Awaiting Review to 3.5

Like #20427, I'd like to at least leave it in deprecated.php in case it is called directly by a plugin. I found at least a few instances in a search of the plugins directory.

comment:4   ryan — 10 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [21353]:

Deprecate and stub _media_button. fixes #21317

Note: See TracTickets for help on using tickets.