Allow filtering of expiration in set_transient()

[wpsmith]

I recently needed to change an expiration of a transient and expected pre_set_site_transient_* filter to be able to do that. However, the filter only affects the value. I recommend adjusting this to affect both.

AFAIK, filters are only supposed to filter the first supplied argument. So $expirationprobably should get its own filter.

Replying to obenland:

AFAIK, filters are only supposed to filter the first supplied argument. So $expirationprobably should get its own filter.

Yes that's right. I knew that! Adjusted patch for one filter.

Site Transient Filter Adjustment, first pass

extract( $options, EXTR_OVERWRITE ); is dangerous and not something we're likely going to do here, as it doesn't fit patterns found throughout. Please do not replace patches, we can't see what changed — I actually can't tell if this was the original patch, or a replacement.

Replying to nacin:

extract( $options, EXTR_OVERWRITE ); is dangerous and not something we're likely going to do here, as it doesn't fit patterns found throughout. Please do not replace patches, we can't see what changed — I actually can't tell if this was the original patch, or a replacement.

My apologies. The first one was VERY much similiar to the one that's there now using extract. I've added a couple more options.

Option 3: New filter

Option 2: Same filter different 2nd value.

Option 1: Reworked, removed extract()

I don't understand how 21330_opt2.patch​ would work in a plugin.

Could you go a bit more into your use case, perhaps some sample code?

Replying to nacin:

I don't understand how 21330_opt2.patch​ would work in a plugin.

Could you go a bit more into your use case, perhaps some sample code?

The expiration time is always set (right? if not set, it's set to 0 by the time of the filter) and is always an integer. For example, wp_check_browser_version() has a set expiration that is known. So...assuming I knew the $key (93ce43dc55bd29ecc99e83ca12b5d7f4) in this example.
`
add_filter( 'pre_set_site_transient_browser_93ce43dc55bd29ecc99e83ca12b5d7f4', 'wps_change_browser_transient' );
function wps_change_browser_transient( $val ) {

if ( is_int( $val ) && 604800 == $val )

$val = 1209600;

return $val;

}
`

However, I am not convinced that this is the best solution...

Option 4: Combo of Option 3 & modified Option 1

In 21330_opt4.patch​, what do you need the option part for? Value and expiration are both filterable at this point.

If we were to do this, it would probably look like 21330.diff​.