Opened 10 months ago
Closed 10 months ago
#21382 closed defect (bug) (fixed)
Twenty Twelve - videos break outside content in responsive layout
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | konstantin@…, dstrojny@… |
Description
We need to account for video responsiveness within the new Twenty Twelve theme. I would recommend adding fitvids.js to the theme to be able to accurately calculate videos with different sizes. A pure CSS solution would involve setting a fixed aspect ratio, which could cause undesirable results for videos that have a non-widescreen aspect ratio.
Attachments (2)
Change History (11)
comment:2
lancewillett — 10 months ago
- Milestone changed from Awaiting Review to 3.5
- Owner set to lancewillett
- Status changed from new to assigned
comment:4
lancewillett — 10 months ago
Chris, I wasn't able to reproduce this one.
Could you tell me how to repeat it? What content to use (video URL and how you entered it into the post) and your browser version and OS.
Screenshots help, too.
comment:5
drewstrojny — 10 months ago
- Cc dstrojny@… added
comment:6
chriswallace — 10 months ago
The video I had an issue with was a Vimeo video, not embedded with oEmbed. This was embedded as an iframe video:
<iframe src="http://player.vimeo.com/video/40912440?title=0&byline=0&portrait=0" frameborder="0" width="620" height="350"></iframe>
This is on the latest version of Chrome on Mac OS X.
Fitvids.js (or a similar PHP solution) is perfect for this problem because it looks for iframes with vimeo.com in the src attribute. CSS can achieve a similar effect, but it's impossible to scale the height based on the width.
- Keywords has-patch added; needs-patch removed
Reproduced and fixed in 21382.diff. Thank you @chriswallace!
Added object and embed for completeness (mimicked from Twenty Eleven).
comment:8
in reply to:
↑ 7
lancewillett — 10 months ago
Replying to obenland:
Reproduced and fixed in 21382.diff. Thank you @chriswallace!
Added object and embed for completeness (mimicked from Twenty Eleven).
The block was already there: http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentytwelve/style.css#L290 -- just needs iframe added.
We shouldn't limit the selector to entry-content because we want comment videos to have the same behavior.
comment:9
lancewillett — 10 months ago
- Resolution set to fixed
- Status changed from assigned to closed
In [21408]:
I think we can get 90% there with CSS, I'll work with Drew and Konstantin to add a patch for testing and feedback. It'd be really nice to avoid loading any extra JS.