Opened 10 months ago
Closed 10 months ago
#21399 closed defect (bug) (fixed)
Twenty Twelve: use protocol relative URL to load Google Fonts
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | konstantin@… |
Description
To avoid insecure content errors in Theme Customizer we should use relative protocol URL in the font CSS enqueue call.
Attachments (3)
Change History (7)
lancewillett — 10 months ago
comment:2
in reply to:
↑ 1
lancewillett — 10 months ago
Prior to 3.5, // is considered a path-relative URL, and the site URL is prepended. So that's a no-go.
We could consider a version check, and then register // if we're good, and otherwise, checking is_ssl(). Not as elegant as a straight is_ssl() check, but at least sets the expectation that you can now do // with enqueues.
Might complicate the theme more than it should, though. I'm fine with a straight is_ssl() check.
comment:4
lancewillett — 10 months ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In [21391]:
Note: See
TracTickets for help on using
tickets.

Won't this mess with back-compat? It was only introduced in [21166].