WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 11 months ago

#21400 closed defect (bug) (fixed)

comment_ID is misspelled in wp_set_wpdb_vars()

Reported by: wonderboymusic Owned by: ryan
Priority: normal Milestone: 3.5
Component: Database Version: 3.0
Severity: normal Keywords: has-patch
Cc:

Description

I was doing some serious debugging of query formatting and noticed comment_ID always being formatted as %s.

Guess why? It's spelled with three (3) Ms = commment_ID in wp_set_wpdb_vars( ), meaning every insert or update without formatting explicitly passed is skipping $wpdb->field_types

Attachments (1)

comment-spelling.diff​ (997 bytes) - added by wonderboymusic 11 months ago.

Download all attachments as: .zip

Change History (4)

wonderboymusic — 11 months ago

comment:1 wonderboymusic — 11 months ago

This is also fixed here: #19019

Last edited 11 months ago by SergeyBiryukov (previous) (diff)

comment:2 SergeyBiryukov — 11 months ago

  • Milestone changed from Awaiting Review to 3.5

comment:3 ryan — 11 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [21363]:

Take the mmm out of comment_ID. Just mm is sufficient.

Props wonderboymusic
fixes #21400

Note: See TracTickets for help on using tickets.