Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#21473 closed defect (bug) (fixed)

Twenty Twelve: Style for comment form button

Reported by: obenland Owned by: lancewillett
Priority: normal Milestone: 3.5
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch
Cc: lancewillett, drewstrojny

Description

The commentform submit button should receive some Theme styling.

Attachments (4)

21473.diff​ (1.4 KB) - added by obenland 10 months ago.
searchform-button.png​ (8.5 KB) - added by obenland 10 months ago.
comment-form.png​ (36.2 KB) - added by obenland 10 months ago.
21473.2.diff​ (1.5 KB) - added by obenland 10 months ago.

Download all attachments as: .zip

Change History (8)

obenland — 10 months ago

obenland — 10 months ago

obenland — 10 months ago

obenland — 10 months ago

comment:1   obenland — 10 months ago

21473.2.diff​ also makes button height browser compatible.

It seems the Firefox bug isn’t really a bug at all, but a “feature”: that is, it’s a deliberate decision by Firefox to limit line heights on buttons. This is evidenced by this line of CSS in Firefox’s default CSS:

button, input[type="reset"], input[type="button"], input[type="submit"] {
        line-height:normal !important;
}

Basically, Firefox is setting the line-height to “normal” on buttons and is enforcing this decision with an !important declaration.

​Source

comment:2   DrewAPicture — 10 months ago

Screenshot following 21473.2.diff > ​http://cl.ly/image/442O3W300F3j

Version 0, edited 10 months ago by DrewAPicture (next)

comment:3   lancewillett — 10 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21438]:

Twenty Twelve: better button styles for consistent look across browsers. Props obenland, fixes #21473.

comment:4   SergeyBiryukov — 10 months ago

  • Milestone changed from Awaiting Review to 3.5
Note: See TracTickets for help on using tickets.