Twenty Twelve: Styling fixes needed for images, galleries, search button and some headings

[chellycat]

I found the following style issues with the theme:

• Headers that span multiple lines need more line-height: ​https://img.skitch.com/20120806-dt814y78r1r1jcexmikhkcn6tt.png and ​https://img.skitch.com/20120806-q8au1q833r8a6bqn33jg71m1i2.png

• The submit button is not the same height as the text field (in both the search widget and on the password protected post: ​https://img.skitch.com/20120806-g5cgpkjqiiwgsd5br18ujfbbdt.png)

• Line-height of entry content becomes compressed when wrapped around images with captions: ​https://img.skitch.com/20120806-rkqgwqhbqc54pp2cmyqk4bfta2.png

• Images resized in editor are full-width: ​https://img.skitch.com/20120806-jxaa29sw6epaujxkf7by1r2up4.png

• Line-heights could be improved on pingbacks: ​https://img.skitch.com/20120806-k5a7x6nq3krb43swrweqmm93n8.png

• Galleries need bottom margin, and gallery captions need styling: ​https://img.skitch.com/20120806-cn98h3q2ny4k1454gb4jpq7eq2.png

Galleries look fine to me on second look.

Makes the top/bottom padding of the submit button even with the input field for search and password forms.

Increases the line-height for multi-line headers just a tad b/c it was looking a bit tight before. I'm aware that the line-heights were calculated following a formula, but multi-line headers were a bit squished. I don't feel that this fix breaks the vertical rhythm too much, but feel free to adjust if needed.

The submit button is not the same height as the text field (in both the search widget and on the password protected post:

I think this is fixed now, can you re-check it?

Removing width: auto from images, which was causing images resized in the editor to appear full width. The "width: auto" is an IE8 specific fix and should be moved to IE8-specific styles.

Please use this attachment instead of "remove-auto-width-on-images.diff", because it has the ticket number appended.

Replying to lancewillett:

The submit button is not the same height as the text field (in both the search widget and on the password protected post:

I think this is fixed now, can you re-check it?

Just ran svn up and checked it again, confirming that it's fixed. Galleries also look fine, so that can be removed from the list.

Adds line-height to entry-content and entry-summary, so that elements appearing outside of paragraph tags inside these containers will still have the appropriate line-heights.

Adds line-height for pingbacks, which was looking too tight when pingbacks spanned multiple lines.

I have uploaded patches for all of the issues reported, except for galleries (they appear to work now, I think I was looking at outdated code for that one. The submit button issue has also already been fixed, as confirmed above).

Thanks for all the patches and notes, Michelle. Noted the IE8 fix suggestion over on #21440.

In [21462]:

Twenty Twelve: line-height style fixes, props chellycat. See #21486.

• For entry titles match larger screen style with the base styles to add a bit more line-height.
• Add line-height to entry-content and entry-summary, so that elements appearing outside of paragraph tags inside these containers will still have the appropriate line-heights.
• Add line-height for pingbacks, which looks a bit too tight when pingbacks span multiple lines.