Move option sanitization in network/settings.php to sanitize_option

[wonderboymusic]

When Networks settings are saved in wp-admin/network/settings.php, the sanitization is done inline. This code needs to be moved to sanitize_option() where all of the other options are sanitized. This also combines duplicated code.

Yes please.

Seems to me like in both cases, we also need to account for the value possibly being an array (someone making a change manually, rather than through settings.php).

Illegal names handling can probably be simplified to:

if ( ! is_array( $value ) )
   $value = explode( ' ', $value );
$value = array_filter( array_map( 'trim', $value ) );
if ( ! $value )
   $value = '';

Also, stripslashes() already occurs in the settings.php handler (just as it does in options.php).

Refreshed the patch - here's a quick and dirty:

update_option( 'illegal_names', array( '', 'Woo', '' ) );
update_option( 'limited_email_domains', array(  'woo', '', 'boo.com', 'foo.net.biz..'  ) );
update_option( 'banned_email_domains', array(  'woo', '', 'boo.com', 'foo.net.biz..'  ) );

print_r( get_option( 'illegal_names' ) );
print_r( get_option( 'limited_email_domains' ) );
print_r( get_option( 'banned_email_domains' ) );
exit();

Cool stuff. Maybe that can become a unit test?

will fire one up fairly soon

Added a unit test and refreshed patch to not save filtered arrays with their original numeric indexes

In [21993]:

Move sanitization for the multisite illegal_names, limited_email_domains, and banned_email_domains options to sanitize_option(). props wonderboymusic. fixes #21552.

​[UT1046]