Adding Imgur as an oEmbed provider

[bradparbs]

Adding imgur to the list of oEmbed providers! (wcgr rocks)

Adding imgur to the list of oEmbed providers

Patch works - great job Brad!

Similar: #11978

The thing is that there are quite a few generic image hosting providers, like imageshack, photobucket etc.

We should have a "canonical" plugin that adds support for all these addition oEmbed providers, instead of adding them to Core.

Replying to scribu:

The thing is that there are quite a few generic image hosting providers, like imageshack, photobucket etc.

We should have a "canonical" plugin that adds support for all these addition oEmbed providers, instead of adding them to Core.

Adding providers is really low cost for us. Knowing that they need a plugin, tracking that plugin down, and installing it, is a big hurdle for users. These "magic" embeds will work better the more that people can rely on popular embed providers to be supported without any effort on their part. I think our hurdle should be the popularity and stability of the embed provider. Imgur has been around for a while, and serves multiple petabytes a month — I think they fit the bill. And FWIW, I'd be happy to add ImageShack and Photobucket too.

Related / please add: #15734

I agree with @markjaquith. Additionally Photobucket is already supported:

http://core.trac.wordpress.org/browser/trunk/wp-includes/class-oembed.php?rev=20874#L44

I think our hurdle should be the popularity and stability of the embed provider. Imgur has been around for a while, and serves multiple petabytes a month — I think they fit the bill.

Agreed.

Related please add #21635

I believe the correct endpoint is just http://api.imgur.com/oembed, and that the regular expression is dangerously missing a slash. (A domain like i.imgur.com.nacin would work.)

Looks like this should additionally be subdomain-agnostic.

Additionally, the endpoint requires at least a height and width of 640 (if either/both are specified) to display ​http://imgur.com/w7zCp, despite it being only 554 x 541. Otherwise, it provides a height/width of 90 x 90. That's pretty lame and needs more research.

Since they have a flaky endpoint, seems like this should be punted for now.

Per IRC, punted until imgur obeys maxwidth and maxheight in a sane way.