Twenty Twelve: Code simplifications (and one tabs > spaces issue)

[obenland]

There are a few opportunities to further streamline the code.

I'll separate my proposals by file, to make it easier to leave changes out that don't find approval.

21685-indentation.diff​: Makes HTML indentation consistent across all template files. Moves to if-endif syntax in homepage.php for consistency.

21685-sidebars.diff​: Consistently calls sidebars with just the ID. Removes unnecessary closing/opening php tags and makes in-code comment consistent with how it is done in other parts of the Theme

21685-comments.diff​: Removes unnecessary closing/opening php tags and indentation

21685-customizer.diff​: No need to put the selector in a variable as it will be called only once anyway

21685-navigation.diff​: Tabs > spaces

21685-theme-options.diff​: No need for extra trues and falses, the conditional already returns the desired result. Capability is set to 'edit_theme_options' by default

In [21616]:

Twenty Twelve: spaces to tabs in navigation.js, props obenland. See #21685.

In [21620]:

Twenty Twelve: consistently call sidebar areas with just the ID value, props obenland. See #21685.

In [21621]:

Twenty Twelve: comments.php, cleanup and better indentation. Props obenland, see #21685.

In [21623]:

Twenty Twelve: theme-options.php fixes from obenland, see #21685.

• Capability is already set to 'edit_theme_options' by default
• Simplify logic for form input validation

I'm going to skip most of the template file indentation fixes -- it's already set up as intended there.

Thanks for all the cleanup, obenland! Great stuff.

In [21643]:

Twenty Twelve: use sidebar ID string value for sidebar checks instead of hard-coded integer, props nacin. See #21685.

condition checked twice

21685.2.diff​ removes a duplicate/misplaced condition in theme-customizer.js

In [22168]:

Twenty Twelve: remove a duplicate/misplaced condition in theme-customizer.js, props DrewAPicture. Closes #21685.