#21732 closed defect (bug) (fixed)
Theme customizer: Background attachment selector has no effect in the customizer
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Appearance | Version: | 3.4.1 |
| Severity: | normal | Keywords: | has-patch needs-testing |
| Cc: | admin@… |
Description
Changing between fixed/scroll has no effect in the customizer, but it does change the background attachment value when you save it and view your site for real.
Attachments (1)
Change History (7)
- Component changed from Themes to Appearance
- Milestone changed from Awaiting Review to 3.5
bainternet — 8 months ago
comment:2
bainternet — 8 months ago
- Cc admin@… added
I took a crack at it and in the customize-preview.js line 132 it's
background-position: top
instead of:
background-attachment:
So i created a quick patch ,tested it a bit and it looks good.
comment:3
bainternet — 8 months ago
- Keywords has-patch needs-testing added
- Owner set to duck_
- Resolution set to fixed
- Status changed from new to closed
In [22131]:
Thanks for the patch bainternet! Just a couple of notes for the future:
- Don't worry about updating minified JS/CSS
- Patching from the root of the trunk checkout is preferred, so svn diff in /path/to/trunk/ instead of /path/to/trunk/wp-includes/js/
comment:6
in reply to:
↑ 5
bainternet — 7 months ago
Replying to duck_:
Thanks for the patch bainternet! Just a couple of notes for the future:
- Don't worry about updating minified JS/CSS
- Patching from the root of the trunk checkout is preferred, so svn diff in /path/to/trunk/ instead of /path/to/trunk/wp-includes/js/
Gotcha :)
Note: See
TracTickets for help on using
tickets.

customize-preview.js and customize-preview.min.js patch