Twenty Twelve: Review overflow attributes

[obenland]

Let's double-check where overflow attributes are really necessary and where they might interfere with the Theme.
We should be leaving only the essential rules for clearing floats and remove the rest.

Related: ​http://themes.trac.wordpress.org/ticket/9199#comment:15

Couldn't reproduce though.

Thanks! :)

To reproduce, check the comment form text with Open Sans activated.

Replying to obenland:

To reproduce, check the comment form text with Open Sans activated.

Thanks, reproduced in Firefox: 21740.comment-form.png​

I'd like to remove the attribute from the following selectors:

• .widget-area .widget: Maybe change that, so that floats could still be used in text widgets. But other than that it seems not to be needed here. Plus it kills the bottom-shadow of the 'Search' button.

• footer[role="contentinfo"]: Nothing floats in the footer.

• .image-attachment: Let's move the overflow attribute to article.attachment, so the image shadow does not get cut off.

• .comments-meta article: Doesn't have any effect. And while we're there: .comments-area article p is redundant.

• #respond form p: Nothing floating there either, but causing above mentioned bug

I'd like to add the attribute to the following selector:

• .entry-content: We pass the "Clearing Floats" Unit Tests only due to clearing help by .entry-meta. We get busted in an Aside when the last element is floated, since the background color doesn't wrap. If accepted, we should also add a word-wrap attribute and an override for image attachements.

Both will probably need more testing then, too.

Replying to obenland:

I'd like to remove the attribute from the following selectors:

Makes sense for all these (noting .comments-area article not -meta), thanks for the notes.

I'd like to add the attribute to the following selector:

Could you explain this one further? I'm not sure I see the importance of it. Maybe a new ticket with screenshots and examples. Otherwise I'd vote to leave it as is for now.

In [21725]:

Twenty Twelve: review and remove unneeded overflow rules, and remove duplicate style block. Props obenland, fixes #21740.