Opened 9 months ago

Closed 9 months ago

#21777 closed enhancement (fixed)

Replace multiple wp_enqueue_script() calls in nav-menus.php with dependencies

Reported by: SergeyBiryukov Owned by: nacin
Priority: normal Milestone: 3.5
Component: Menus Version:
Severity: normal Keywords: has-patch
Cc:

Description

Replying to nacin:

Looking at wp-admin/nav-menus.php, looks like a lot of those lines should be removed in favor of dependencies.

Attachments (1)

21777.patch​ (1.4 KB) - added by SergeyBiryukov 9 months ago.

Download all attachments as: .zip

Change History (4)

SergeyBiryukov — 9 months ago

comment:1   SergeyBiryukov — 9 months ago

Didn't include 'common', since it's already enqueued in admin.php:
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/admin.php#L81

comment:2   nacin — 9 months ago

  • Milestone changed from Awaiting Review to 3.5

Note that postbox.js has jquery-ui-sortable as a dependency, but I am leaving it in 21777.patch​ because sortable is also used on that screen for the nav menus, not just postboxes.

comment:3   nacin — 9 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21696]:

Replace multiple wp_enqueue_script() calls in nav-menus.php with dependencies. props SergeyBiryukov. fixes #21777.

Note: See TracTickets for help on using tickets.