Opened 10 months ago
Last modified 9 months ago
#21826 new enhancement
There should be more filters when displaying a theme in the list table
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Awaiting Review |
| Component: | Administration | Version: | 3.4 |
| Severity: | normal | Keywords: | has-patch |
| Cc: |
Description
In WP_Themes_List_Table::display_rows(), there is a filter for the theme actions, but no filters for the theme information itself: screenshot, title, author, version, and description. Why not fix that?
The attached patch introduces theme_list_* filters within the display_rows() method. Suppressing one of the pieces of information is simply a matter of returning an empty value through the filter.
Attachments (2)
Change History (5)
comment:2
in reply to:
↑ 1
ethitter
— 10 months ago
Replying to scribu:
I think a single filter for all the theme's attributes would make more sense. And WP_Theme might actually already have it.
A single filter would certainly be more efficient and seems fine. I'll work up a new patch.
I'm not opposed to adding filters in WP_Theme (if they don't already exist; I couldn't find any), but I'd rather those be a separate set. Discerning context from filters in WP_Theme will be challenging, and I think many uses of the filters will be context-specific rather than universal.
comment:3
SergeyBiryukov
— 9 months ago
- Version changed from trunk to 3.4
I think a single filter for all the theme's attributes would make more sense. And WP_Theme might actually already have it.