Opened 8 months ago

Closed 8 months ago

#21839 closed enhancement (fixed)

Audit use of return-by-reference

Reported by: wonderboymusic Owned by: ryan
Priority: normal Milestone: 3.5
Component: Performance Version: 3.4.1
Severity: normal Keywords: has-patch
Cc:

Description

(The component for this ticket is Performance because nothing else made any sense)

This has come up in other tickets, and each time it has been recommended that we remove the return by reference indicators when present on functions and class methods. From php.net:

Do not use return-by-reference to increase performance. The engine will automatically optimize this on its own. Only return references when you have a valid technical reason to do so.

Is there a valid technical reason to still do so? Since PHP5, objects are always passed by reference.

Attachments (3)

return-by-ref-audit.diff​ (8.2 KB) - added by wonderboymusic 8 months ago.
21839.i18n.png​ (67.0 KB) - added by SergeyBiryukov 8 months ago.
21839.mo.diff​ (542 bytes) - added by SergeyBiryukov 8 months ago.

Download all attachments as: .zip

Change History (8)

wonderboymusic — 8 months ago

comment:1   ryan — 8 months ago

  • Milestone changed from Awaiting Review to 3.5
  • Version set to 3.4.1

comment:2   ryan — 8 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [21792]:

Remove unnecessary return by refs. Props wonderboymusic. fixes #21839

SergeyBiryukov — 8 months ago

SergeyBiryukov — 8 months ago

comment:3   SergeyBiryukov — 8 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

[21792] totally broke i18n: 21839.i18n.png​. 21839.mo.diff​ fixes that.

comment:4   wonderboymusic — 8 months ago

eek, sorry bout that

comment:5   ryan — 8 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [21793]:

Restore return by ref for make_entry(). Props SergeyBiryukov. fixes #21839

Note: See TracTickets for help on using tickets.